Join development team

Started by yoyoz, June 01, 2023, 08:41:58 AM

Previous topic - Next topic

0 Members and 1 Guest are viewing this topic.

yoyoz

Hello,
i have discovered neolemming 2 days ago. Im very happy to see this, and I am very happy to share this game with my son in 2023.
I want to fix some bugs. Im developper (PHP, JS, and old VB6). I dont know delphi, but i try to compile sources.
I have added GR32 lib, and now when i compile: i have a lot of errors :[dcc32 Erreur] LemGame.pas(3005): E2010 Types incompatibles : 'Cardinal' et 'TColor32'

Can you help me to fix this? Maybe later, i can fix some issues to improve your game.
Thanks

WillLem

#1
Quote from: yoyoz on June 01, 2023, 08:41:58 AM
Hello,
i have discovered neolemming 2 days ago. Im very happy to see this, and I am very happy to share this game with my son in 2023.

Hi, welcome to the Forums :)

Quote from: yoyoz on June 01, 2023, 08:41:58 AM
I want to fix some bugs. Im developper (PHP, JS, and old VB6). I dont know delphi, but i try to compile sources.
I have added GR32 lib, and now when i compile: i have a lot of errors

I've posted some instructions for compiling NL source here; I had most of the same issues when I first tried to compile, but namida (NL dev) helped me through the process with these instructions.

If you're interested in helping with development, I'm currently working on a fork of NeoLemmix called SuperLemmix (the source can be found here, the compilation instructions given above are exactly the same for this). I would definitely be welcoming of help/input from other developers if you're wanting to get involved and work on it as part of a team.

IchoTolot

Quote from: yoyoz on June 01, 2023, 08:41:58 AM
Hello,
i have discovered neolemming 2 days ago. Im very happy to see this, and I am very happy to share this game with my son in 2023.
I want to fix some bugs. Im developper (PHP, JS, and old VB6). I dont know delphi, but i try to compile sources.
I have added GR32 lib, and now when i compile: i have a lot of errors :[dcc32 Erreur] LemGame.pas(3005): E2010 Types incompatibles : 'Cardinal' et 'TColor32'

Can you help me to fix this? Maybe later, i can fix some issues to improve your game.
Thanks


Welcome to the forums! :)

I would also like to add that if you are planning to fix bugs please first make a topic about what you would consider fixing.

For new versions we first discuss if a thing is indeed in need of fixing or even the way it should be fixed. Especially if we are talking physics updates!

Maybe take a look through the "Bugs&Suggestions" board first and see how things usually develop.

The normal way would be:

1.) Report issue in a topic.
2.) Discussion + Decision
3.) For critical things (usually physics): Implement fix in an experimental version for public test.
4.) If test is successful and no bigger problems arise -> Implement the fix in the next version.

yoyoz

Thanks you for your help.
i can compile it now.

I have created an issue here: https://bitbucket.org/namida42/neolemmixplayer/issues/81/when-you-restart-a-level-same-actions
There is a problem when you click on restart button: Same actions are replay. I have fixed it.
But for the moment, i havent found where fix when you restart the level with the menu screen.


IchoTolot

Quote from: yoyoz on June 01, 2023, 07:59:30 PM
Thanks you for your help.
i can compile it now.

I have created an issue here: https://bitbucket.org/namida42/neolemmixplayer/issues/81/when-you-restart-a-level-same-actions
There is a problem when you click on restart button: Same actions are replay. I have fixed it.
But for the moment, i havent found where fix when you restart the level with the menu screen.

That is intended if you are referring to the restart button in the UI. This button is not a restart, but a "replay" button.

If you restart/replay a level your previous actions are still saved and replayed until you stop the replay with a simple left-click inside the play-area.

This avoids you accidentally throwing away all your progress in a level as that can be very frustraiting after accidentally losing your progress on a longer level - or you just want to change your approach from a certain point on in your current attempt.

The replay-mode is indicated through red "R" on the left side of the status bar.

yoyoz

Sorry, i dont know it.
Do you have a documentation for features like this, UI buttons , netplay ... ?

Thanks

IchoTolot

I made a manual ages ago, but I fear it is a quite outdated currently. (Link to it, but no promises here: https://www.lemmingsforums.net/index.php?topic=4081.0)

I would rather suggest playing the NeoLemmix Introduction Pack (Link: https://www.lemmingsforums.net/index.php?topic=5204.0) that also covers most new NeoLemmix features and a lot of tricks. This should be the best way to get comfortable with the engine and Lemmings in general.

To be honest, I think you are currently the first to ask for a complete documentation and go straight to the code. ;)

If you have any questions though feel free to create a topic or maybe even join and ask on our discord server: https://www.lemmingsforums.net/index.php?topic=3062.0

Simon

The glaring bug here is that NeoLemmix doesn't tell how to cancel the replay (click into the air). I'm beginning to think that NeoLemmix should write that in big fat letters during replay.

You aren't the first to be confused on how to cancel the replay. I've heard about this confusion in Lix at least once before, and in NeoLemmix IIRC also another time before. It's a terrible problem. It has the potential to discourage new players from the hobby, and they'll never ask about it.

Welcome to the forums!

-- Simon

WillLem

Quote from: yoyoz on June 01, 2023, 07:59:30 PM
But for the moment, i havent found where fix when you restart the level with the menu screen.

I have already fixed this in SuperLemmix, it's been implemented as both a baked-in feature of Classic Mode and as a toggleable option, so users can have whichever behaviour they prefer.

You're welcome to use the same fix if you wish, let me know if you want some help with it.

namida

There's no "fix" because this is not a bug; it's the intended behavior.
My projects
2D Lemmings: NeoLemmix (engine) | Lemmings Plus Series (level packs) | Doomsday Lemmings (level pack)
3D Lemmings: Loap (engine) | L3DEdit (level / graphics editor) | L3DUtils (replay / etc utility) | Lemmings Plus 3D (level pack)
Non-Lemmings: Commander Keen: Galaxy Reimagined (a Commander Keen fangame)

IchoTolot

There is a discussion to be had if and how it can be visually more striking. The red "R" relies much on the user's familiarity with WinLems where the replay mode is also used.

There I agree with Simon. --> Even lix would run into the same problem as he explained! :8():   (Although the blinking is a little bit more striking there)

But yeah, WillLem's fix is not a fix but rather a toggable removal that does not fix the core Issue (replay-mode not being recognisable enough).
Even worse: By simply turning it off from the start a user would never experience the upsides of having it assisting you!

When it is visible from the get-go what's going on here then there would be nothing more to fix and no more confusion.

kaywhyn

I don't have too much experience with Lix myself, but from what I have seen from the times I have played with it, what I like about Lix, in contrast to NL, is how the hotkeys for everything are all on the screen for you. Therefore, you don't have to worry what they are in case you forget. Yes, it is quite cluttered as a result, but it does make the UI more user-friendly. It even tells you when you're in replay mode to click to cancel. Not so in NL. The other way to cancel replay mode is with the C key, but I never use that. I always use mouse clicks to cancel replay mode.

At the same time, because I'm so used to the hotkeys of NL, I ended up changing all of Lix's to match NL's, meaning FF is F, Restart is R, etc. The one thing I do miss is the lack of a hotkey for "last skill assigned," as I find it super helpful when I'm LPing NL content. Of course, this will likely be a problem when doing Lix multiplayer, but that's because I haven't settled on a hotkey configuration for the skills, and in NL I don't ever use hotkeys to select skills, I always use the mouse to do so. Yea, I'm a bit of an odd horse this way :P I guess I just find it quicker to click with the mouse and how I'm more used to playing that way instead of with hotkeys.
https://www.youtube.com/channel/UCPMqwuqZ206rBWJrUC6wkrA - My YouTube channel and you can also find my playlists of Lemmings level packs that I have LPed
kaywhyn's blog: https://www.lemmingsforums.net/index.php?topic=5363.0

Dullstar

Quote from: kaywhyn on June 02, 2023, 11:54:26 AM
I don't have too much experience with Lix myself, but from what I have seen from the times I have played with it, what I like about Lix, in contrast to NL, is how the hotkeys for everything are all on the screen for you. Therefore, you don't have to worry what they are in case you forget. Yes, it is quite cluttered as a result, but it does make the UI more user-friendly. It even tells you when you're in replay mode to click to cancel. Not so in NL. The other way to cancel replay mode is with the C key, but I never use that. I always use mouse clicks to cancel replay mode.

At the same time, because I'm so used to the hotkeys of NL, I ended up changing all of Lix's to match NL's, meaning FF is F, Restart is R, etc. The one thing I do miss is the lack of a hotkey for "last skill assigned," as I find it super helpful when I'm LPing NL content. Of course, this will likely be a problem when doing Lix multiplayer, but that's because I haven't settled on a hotkey configuration for the skills, and in NL I don't ever use hotkeys to select skills, I always use the mouse to do so. Yea, I'm a bit of an odd horse this way :P I guess I just find it quicker to click with the mouse and how I'm more used to playing that way instead of with hotkeys.

IIRC the C hotkey almost got culled, and as far as I know I might be the only one that uses it.

I think a lot of people use the mouse to select skills in NL though; the learning curve for the hotkeys is fairly steep because of how much separation there is between where you can look up the hotkeys and where you can actually apply them. In Lix, if you don't remember the hotkey, you can just look at the button and then press the button it says. In NL you have to completely stop playing to go to the options menu and check, which probably means going back to the main menu (I forget if you can access it or not during gameplay, but while we're on the topic of forgetting what the hotkeys were, it doesn't really matter if it's accessible in-game or not if you gotta go back to the main menu to be able to produce the options menu without a hotkey). That's why it's much faster to click with the mouse in NL: technically if you knew the skill hotkeys, it would be faster, but the lookup process is insanely long.

The old "push buttons until you figure out what they do" approach really only works well on console games where there's not that many buttons to choose from. The keyboard has far too many buttons for that.

WillLem

#13
Quote from: namida on June 02, 2023, 03:44:09 AM
There's no "fix" because this is not a bug; it's the intended behavior.

I understand that. My own use of the word "fix" was mainly responding to the OP's use of the word in reference to the undesired behaviour. Either way though, it's a figure of speech; if someone perceives the behaviour as undesirable, despite it being intended, then their perception will probably also be that the behaviour has been "fixed".

EDIT - heh, I'm sure there will be people who consider SLX "broken" now that direct drop and solid sides are back ;P

Quote from: IchoTolot on June 02, 2023, 06:25:20 AM
But yeah, WillLem's fix is not a fix but rather a toggable removal that does not fix the core Issue (replay-mode not being recognisable enough)

There are plans to display the animated "R" graphics on screen (like in WinLemm and SuperLemmini) so I'm pretty sure this will make it clear enough what's going on; I can already draw stuff to the screen, I just need to figure out how to to it at specific times, and for specific durations. It's on its way, though.

A popup the first time it happens could also be a good idea, but - as has been said - more discussion is needed around those kind of specifics.

Quote from: IchoTolot on June 02, 2023, 06:25:20 AM
By simply turning it off from the start a user would never experience the upsides of having it assisting you!

This is intentional, since SuperLemmix is about presenting the game in a more traditional fashion without losing any of the modern advantages - it's in response to those people who have complained about NeoLemmix's entering Replay mode automatically. Even if you know how to cancel it, it can still sometimes be undesirable. i get your point though, anyone that doesn't venture into the settings menu might miss the fact that the feature exists at all, but that's true of any setting that isn't activated by default.

Quote from: IchoTolot on June 02, 2023, 06:25:20 AM
Even worse:

It literally isn't worse. Making any highly visible/gameplay-affecting behaviour optional is nearly always preferable. With that said, if an agreement can be reached on how best to handle "enter auto-Replay mode even when player doesn't have any reason to expect it", then I'll likely revert to having the option on by default.

Either way, it's not a problem. I'm more than happy to respond to feedback in order to make SuperLemmix as good as it can be.

IchoTolot

WillLem I think you need to see that I don't make any change suggestions or general proposals for SuperLemmix here! :8(): (This is the NL board after all ;))

So you do not need to defend your SLX design decisions before me here - do as you please there!


The only thing I stated is that for NL your "fix" made in SuperLemmix is not a fix at all and would make things even worse when keeping NL's core puzzle-centric philosophy in mind.

I see replay-mode as an integral part of it and even the option to toggle it off as secondary or even cullable (as turning off skill shadows). Again, NL only! SLX you can go ahead!

Therefore, the only discussion I am interested in is making the replay-mode clearer to notice in NL for newer players who are so far only used to execution-based engines.

WillLem

Quote from: IchoTolot on June 02, 2023, 11:31:42 PM
WillLem I think you need to see that I don't make any change suggestions or general proposals for SuperLemmix here! :8(): (This is the NL board after all ;))

So you do not need to defend your SLX design decisions before me here - do as you please there!

Fair enough, but it's hardly worth making a separate topic just to reply to one comment! ;P

In any case, please re-consider my reply a contribution to the discussion in general. The reasons for the decision to make replay mode more background, and optional, provide a valid counter-point to the views you've put forward, especially in the context of a discussion in which the OP stated that the default NL replay behaviour is undesirable.

Quote from: IchoTolot on June 02, 2023, 11:31:42 PM
Therefore, the only discussion I am interested in is making the replay-mode clearer to notice in NL for newer players who are so far only used to execution-based engines.

Agreed. Going forward on that basis, then, I'd suggest that the Replay "R" ought to be displayed on-screen more predominantly, rather than in the panel area (which is already busy enough as it is).

I'm undecided as to how exactly the game should alert the player that they can cancel replay mode, but here are some suggestions:

1) The "R" graphic could be given an upgrade so it actually spells out "Replay" in medium-sized letters, with "Press <hotkey> to cancel" in smaller letters beneath it

2) Keep the "R" graphic as it is, and - as Simon suggested - display "Press <hotkey> to cancel" in large letters, front and centre, but have this only display one time

3) A simple once-only/"don't show again" popup might even suffice, but feels a bit less "video-gamey"

IchoTolot

My gut feeling would say Option 2 (Maybe in the bottom left corner for a few secs), but I need to sleep over it again. :)

yoyoz

I agree, 2 is the best choice.

kaywhyn

Quote from: Dullstar on June 02, 2023, 05:01:24 PM
I think a lot of people use the mouse to select skills in NL though; the learning curve for the hotkeys is fairly steep because of how much separation there is between where you can look up the hotkeys and where you can actually apply them. In Lix, if you don't remember the hotkey, you can just look at the button and then press the button it says. In NL you have to completely stop playing to go to the options menu and check, which probably means going back to the main menu (I forget if you can access it or not during gameplay, but while we're on the topic of forgetting what the hotkeys were, it doesn't really matter if it's accessible in-game or not if you gotta go back to the main menu to be able to produce the options menu without a hotkey). That's why it's much faster to click with the mouse in NL: technically if you knew the skill hotkeys, it would be faster, but the lookup process is insanely long.

The funny thing is that I grew up with the Dos version of Lemmings. I occasionally used the F function keys to select skills, but most of the time it was via the mouse. Instead, the only function key I usually used was the one for pause (F11), as well as the builder (F7) and bomber (F5). I think the one for builder is because it's the most used skill in the game and hence I took to memorizing the function key for it. However, I think in both cases it was just the function key itself, being somewhat iconic themselves.

Now, in NL I only use the P key for pausing, even though F11 can still be used for pausing too. Thus, when I finally came back to checking out something on the Dos port of Lemmings earlier this year, I'm so used to hitting P for pause that I forgot that you cannot do so via that key on Dos! Needless to say, using F11 for pause is probably going to be the one very hard thing for me to come back to doing, if I ever, say, LP that port of the game, similar to what Colorful Arty did for V-Day for his stream of the game.

No, you can't access the main menu during gameplay. Instead, you need to exit out first to the post-results screen and then again to get to the main menu. So, it does indeed take a while to access it in-game when you're in a level.



Regarding notifying the player how to cancel replay mode, I guess another option could be to have a toggable button for it in the skill panel. Similar to how there's one for CPM if you don't use the compact skill panel and you can activate it either by hotkey (T for the traditional layout) or click the button for it, the same thing can happen with the replay cancel button. However, the problem here is that this would mean another change to the UI, and I don't know if the result would still look fine even with just an extra button added. Just a thought really, but I thought I could just throw it out there just in case. 
https://www.youtube.com/channel/UCPMqwuqZ206rBWJrUC6wkrA - My YouTube channel and you can also find my playlists of Lemmings level packs that I have LPed
kaywhyn's blog: https://www.lemmingsforums.net/index.php?topic=5363.0