[DISC][PLAYER] Portal animation appearance and length

[namida]

Currently, the portal has a kind of "twinkle" effect over the lemming for 3 frames before, and 3 frames after, he moves to the receiving portal. The lemming himself is invisible on the last frame before moving, and the first frame after moving.

I'm not particularly opposed to keeping this design itself to be honest, but if anyone has other ideas, let's hear them.

Since the public exp is not out yet, here's a video of the current effect in action: https://youtu.be/vTJvH0AbZgo

[namida]

Everyone's happy with the current settings, then?

The visual effect can be tweaked later if there's strong preference for it, but once we go to RC, the timing will be locked in.

* RC is not imminent at this stage, to be clear

[WillLem]

The timing seems fine. Instant would look a bit odd, with no visual indication that anything has happened other than the lem disappearing suddenly. A few frames with a flashing star seems the best way, for sure.

Just one question: is the flashing star graphic baked into the object, the portal code itself, or is it a lem state?

[namida]

Just one question: is the flashing star graphic baked into the object, the portal code itself, or is it a lem state?

It's globally-fixed, much like the Stoner graphic. This could be changed, but won't be changed until the Portal is confirmed for inclusion. You can find the graphic in gfx/mask/ if you wanted to experiment with modifying it; it's not possible (without altering the code and recompiling NL) to change the number of frames.

[namida]

Doesn't seem anyone has much to say on this, so I think we can assume the current setup is fine. The graphic could still be changed during the RC phase if we feel it's necessary.