[SUG][PLAYER] Remove support for *not* having a username

Started by namida, March 04, 2020, 07:28:33 PM

Previous topic - Next topic

0 Members and 1 Guest are viewing this topic.

namida

As of a few versions back (12.6 IIRC), NeoLemmix allowed players to enter a username. This name is saved into replay files, and is used to identify your own replays vs other people's so that your records don't get overwritten from watching other people's replays.

Recently, a bug has arisen specifically in cases where people do not have a username entered. Prior to this, no bugs were known, but of course the "your replays vs others' replays" distinction couldn't be made when no username is entered - which did need additional code specifically to handle it.

The obvious solution here is to simply not allow no username. This could either be via specifically rejecting such input, or alternatively, by generating a random string of letters / numbers if the user does not enter a username / if the config file doesn't contain one / etc.

Does anyone feel there is a strong reason why this change should not occur? Keep in mind that nothing forces you to use your real name (or your forum username; you could literally just enter a random string of characters) in the username field.
My projects
2D Lemmings: NeoLemmix (engine) | Lemmings Plus Series (level packs) | Doomsday Lemmings (level pack)
3D Lemmings: Loap (engine) | L3DEdit (level / graphics editor) | L3DUtils (replay / etc utility) | Lemmings Plus 3D (level pack)
Non-Lemmings: Commander Keen: Galaxy Reimagined (a Commander Keen fangame)

namida

Implemented in commit 89ef402. "Anonymous" will still be accepted as input (and will be the fallback if the user tries to enter an empty name), but it's not special in any way - it just means "Anonymous" gets used as the username.
My projects
2D Lemmings: NeoLemmix (engine) | Lemmings Plus Series (level packs) | Doomsday Lemmings (level pack)
3D Lemmings: Loap (engine) | L3DEdit (level / graphics editor) | L3DUtils (replay / etc utility) | Lemmings Plus 3D (level pack)
Non-Lemmings: Commander Keen: Galaxy Reimagined (a Commander Keen fangame)