Lemmings Forums

Lix => Lix Main => Topic started by: Simon on June 04, 2023, 10:41:31 PM

Title: Next Bugs to Prioritize
Post by: Simon on June 04, 2023, 10:41:31 PM

Forestidia suggests to fix:

github #375: Sound/Music Volume, Apply/Preview Changes Immediately, Before OK (https://github.com/SimonN/LixD/issues/375)
github #367: Rep4Lev, interrupt, re-win: New Replay saved to wrong dir (https://github.com/SimonN/LixD/issues/367)
github #361: Editor: Show Grid Lines (https://github.com/SimonN/LixD/issues/361)
github #362: Warn about MP3 in main menu (unsupported but common format) (https://github.com/SimonN/LixD/issues/362)

In particular, Sound/music volume previewing is a big quality-of-life feature, more important than it might seem.

-- Simon

Title: Re: Next Bugs to Prioritize
Post by: Simon on September 01, 2023, 02:37:41 AM

github #375: Sound/Music Volume, Apply/Preview Changes Immediately, Before OK (https://github.com/SimonN/LixD/issues/375)]

This is fixed since 0.10.12 from June 2023.

---

github #362: Warn about MP3 in main menu (unsupported but common format) (https://github.com/SimonN/LixD/issues/362)

This is fixed since 0.10.15 from August 2023 (earlier this week).

You can now copy MP3 files into music/ and Lix will play them.

The fix was: I don't exclude .mp3 anymore in my music handling. MP3 files play well on Windows with contemporary Allegro, e.g., Allegro 5.2.8.0, if I don't hardcode such an exclusion in Lix. Effectively, I did no hard work at all and the Heinzelmännchen fixed the bug for me.

Curiously, MP3 worked before 0.10.12, but for the sound/music volume previewing fix (#375, see above in this post), I rewrote some music code and added that exclusion of .mp3. Eventually, Flopsy popped into IRC and asked why MP3 didn't work in 0.10.14, as he remembered MP3 to work before.

Allegro needs MiniMP3 on Linux or Mac, which is not provided in, e.g, the Arch Linux Allegro 5 package. Thus, on Linux or Mac, you don't necessarily have MP3 support from the get-go. That's not a bug in Lix. But we should still remember this because people will consider it a bug in Lix; we should then point people to the missig dependencies.

Thus: This fixes #362, "Warn about MP3 in main menu (unsupported but common format)", without adding a warning, because we'll consider MP3 supported. On Windows, where it probably matters most, Allegro 5 supports MP3 very well in practice.

---

github #367: Rep4Lev, interrupt, re-win: New Replay saved to wrong dir (https://github.com/SimonN/LixD/issues/367)
github #361: Editor: Show Grid Lines (https://github.com/SimonN/LixD/issues/361)

These are still open.

-- Simon